Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossbeam-channel – EOL chan #25

Closed
jnicholls opened this issue Nov 27, 2017 · 6 comments
Closed

crossbeam-channel – EOL chan #25

jnicholls opened this issue Nov 27, 2017 · 6 comments

Comments

@jnicholls
Copy link

jnicholls commented Nov 27, 2017

#@BurntSushi I would suggest checking out crossbeam-channel and if you feel it's a replacement for chan, point people to it in your README to defragment the mpmc situation a little bit. Thanks for all you do.

@BurntSushi
Copy link
Owner

I haven't tried it yet, but yeah, when I do, if I think it sufficiently replaces this crate then I would be happy to retire it and point folks to crossbeam-channel. I suspect my three biggest concerns are this:

  1. What does writing a select look like?
  2. Do channels block or are they constantly spinning?
  3. I will probably want a replacement for chan-signal, although I suspect that would be easy enough to build on crossbeam-channel.

I'm on mobile, so I haven't done my due diligence on the above concerns.

@BurntSushi
Copy link
Owner

Okay, I just read the crate docs and I'm super impressed. It seems all of my concerns are satisfied. I'll give it a try in my cmail and fst commands, and assuming all goes well, I'll EOL chan.

@ghost
Copy link

ghost commented Nov 27, 2017

I'll give it a try in my cmail and fst commands

Please do! If you have any feedback, let me know. :)

So far I've written a fairly extensive suite of unit tests and managed to switch Servo from mpsc to crossbeam-channel without any problems. However, the crate was released only yesterday, so right now I want as much real-world testing as possible so that we uncover and fix all potential bugs (if there are any).

@ghost
Copy link

ghost commented Jun 11, 2018

Just published version 0.2.0 of crossbeam-channel:
https://docs.rs/crossbeam-channel/0.2.0/crossbeam_channel/

The interface of these two crates is now almost identical.

@BurntSushi
Copy link
Owner

For anyone coming here: my intent is still to EOL chan and update the README, but I'm behind in variety of book-keeping work.

@BurntSushi
Copy link
Owner

This is done. I've spread the word that chan is dead! Long live crossbeam-channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants