Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore: updating crossbeam-channel dep to 0.4 #1423

Closed
calebcartwright opened this issue Nov 8, 2019 · 2 comments
Closed

ignore: updating crossbeam-channel dep to 0.4 #1423

calebcartwright opened this issue Nov 8, 2019 · 2 comments

Comments

@calebcartwright
Copy link

Just wanted to see if there were any plans to update the crossbeam-channel dependency to v0.4.0 in ignore, and if so, if there's a ballpark timeline?

There was an issue with crossbeam-utils v0.6.6 (which crossbeam-channel depends on) that has subsequently been fixed on the crossbeam side and recently released (v0.7.0)
rust-lang/rust#65424
crossbeam-rs/crossbeam#435

Ignore is pinned to crossbeam-channel v0.3.6, and that version of crossbeam-channel has a ^0.6.x dependency on crossbeam-utils, preventing the ability to use the fixed version (v0.7.0) of crossbeam-utils

crossbeam-channel = "0.3.6"

Folks have been able to work around that issue (for example by pinning utils to v0.6.5 in the lockfile) so it's not a terribly urgent item, but it would be nice to be able to avoid this.

@ctaggart
Copy link

I'm actually not sure how to workaround this. The error I get is:

error[E0432]: unresolved import `crossbeam_utils::atomic`
 --> /Users/cameron/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/crossbeam-channel-0.3.9/src/flavors/tick.rs:8:22
  |
8 | use crossbeam_utils::atomic::AtomicCell;
  |                      ^^^^^^ could not find `atomic` in `crossbeam_utils`

Using cargo tree, I can see the dependency is brought in from this project.

│   ├── ignore v0.4.10
│   │   ├── crossbeam-channel v0.3.9
│   │   │   └── crossbeam-utils v0.6.6
│   │   │       ├── cfg-if v0.1.10 (*)
│   │   │       └── lazy_static v1.4.0 (*)

@BurntSushi
Copy link
Owner

Fixed in #1457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants