Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --maxdepth to --max-depth #967

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Conversation

okdana
Copy link
Contributor

@okdana okdana commented Jun 26, 2018

The name of the --maxdepth option is inconsistent with all of the other --max-* options, and aside from being aesthetically displeasing it affects the ordering in the help output and completion results. I assume the wording maxdepth comes from find, and that makes sense on its own i guess, but... it just feels out of place to me here.

This PR changes the canonical name of the option to max-depth, leaving maxdepth as a hidden alias for backwards compatibility.

(I realise this is petty; feel free to just close if i'm being too ridiculous...)

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah. I like it. You're right about its provenance; I wanted to match find. But you're also right about everything else too. 👍

@BurntSushi BurntSushi merged commit b38b101 into BurntSushi:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants