Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep crate doesn't seem to need memmap dependency #295

Closed
Dr-Emann opened this issue Dec 27, 2016 · 1 comment
Closed

Grep crate doesn't seem to need memmap dependency #295

Dr-Emann opened this issue Dec 27, 2016 · 1 comment

Comments

@Dr-Emann
Copy link

I don't see anywhere in the grep crate which requires the memmap crate, which is specified in the Cargo.toml. I assume this was probably an artifact of the grep crate once being part of ripgrep, which requires memmaps.

@BurntSushi
Copy link
Owner

@Dr-Emann Thanks for noticing that!

You're indeed correct. In the long ago, ripgrep (formerly called rep) was my playground for testing the regex library. I initially tried to move all search code into a separate grep crate, but couldn't quite figure out how to do it. So I ended up splitting a good chunk of it back out into ripgrep proper, and probably just forgot to get rid of the memmap dependency.

I am planning on moving the search code back into the grep crate, at which point, the memmap dependency may return. (What I know now that I was missing before is that the search code needs to be abstract over a sink/printer interface.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants