Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size is not actually checked on Windows #52

Open
Sh4rK opened this issue May 18, 2021 · 1 comment
Open

File size is not actually checked on Windows #52

Sh4rK opened this issue May 18, 2021 · 1 comment

Comments

@Sh4rK
Copy link

Sh4rK commented May 18, 2021

I was checking out the source of this library purely out of interest, and while the comments and docs say at a few places that file size is compared on windows to avoid some false positives, this does not actually seem to be the case.

The key used for comparison on Windows is

struct Key {
    volume: u64,
    index: u64,
}

which does not include the file size, nor could I find any other place where file size is taken into account.

@BurntSushi
Copy link
Owner

Hmmm. It looks like it got dropped a long time ago in this commit: bbf6959

Sadly, I did not mention it in the commit message and I have no idea now why I dropped the file size comparison. That is not up to my usual standards, sorry about that.

I think in principle I'd be okay adding it back. I can't think of a reason why I dropped it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants