Fix MacOS Builds

[maltfield]

Describe the bug

Builds on MacOS are failing again. Example:

• https://github.com/BusKill/buskill-app/actions/runs/5233608248/jobs/9449191376

[maltfield]

Tail of the build log from the latest build attempt on MacOS

• https://github.com/BusKill/buskill-app/actions/runs/5233608248/jobs/9449191376

2023-06-11T05:02:39.0949630Z Collecting python-gnupg
2023-06-11T05:02:39.1774970Z   Downloading python_gnupg-0.5.0-py2.py3-none-any.whl (18 kB)
2023-06-11T05:02:39.1864360Z   Saved ./python_gnupg-0.5.0-py2.py3-none-any.whl
2023-06-11T05:02:39.1881990Z Successfully downloaded python-gnupg
2023-06-11T05:02:39.8096200Z + /usr/local/Cellar/python/3.7.8/Frameworks/Python.framework/Versions/3.7/bin/python3.7 -m pip download python-gnupg
2023-06-11T05:02:40.3333490Z Collecting python-gnupg
2023-06-11T05:02:40.3340430Z   File was already downloaded /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/python_gnupg-0.5.0-py2.py3-none-any.whl
2023-06-11T05:02:40.3467860Z Successfully downloaded python-gnupg
2023-06-11T05:02:40.4096380Z ++ ls -1
2023-06-11T05:02:40.4098050Z ++ head -n1
2023-06-11T05:02:40.4126340Z + filename=python_gnupg-0.5.0-py2.py3-none-any.whl
2023-06-11T05:02:40.4140350Z ++ curl -s https://pypi.org/simple/python-gnupg/
2023-06-11T05:02:40.4144730Z ++ grep -oE 'https://.*python_gnupg-0.5.0-py2.py3-none-any.whl#'
2023-06-11T05:02:40.4147180Z ++ sed s/#/.asc/
2023-06-11T05:02:40.6250680Z + signature_url=https://files.pythonhosted.org/packages/83/e8/44c05b10888c907e8e327f17f257655a25a3ebe44772b77ef87b5fb336c2/python_gnupg-0.5.0-py2.py3-none-any.whl.asc
2023-06-11T05:02:40.6251680Z + wget https://files.pythonhosted.org/packages/83/e8/44c05b10888c907e8e327f17f257655a25a3ebe44772b77ef87b5fb336c2/python_gnupg-0.5.0-py2.py3-none-any.whl.asc
2023-06-11T05:02:40.7317270Z dyld[11344]: Library not loaded: '/usr/local/opt/libunistring/lib/libunistring.2.dylib'
2023-06-11T05:02:40.7319490Z   Referenced from: '/usr/local/Cellar/wget/1.20.3_2/bin/wget'
2023-06-11T05:02:40.7326580Z   Reason: tried: '/usr/local/opt/libunistring/lib/libunistring.2.dylib' (no such file), '/usr/local/lib/libunistring.2.dylib' (no such file), '/usr/lib/libunistring.2.dylib' (no such file), '/usr/local/Cellar/libunistring/1.1/lib/libunistring.2.dylib' (no such file), '/usr/local/lib/libunistring.2.dylib' (no such file), '/usr/lib/libunistring.2.dylib' (no such file)
2023-06-11T05:02:40.7333950Z build/mac/buildDmg.sh: line 192: 11344 Abort trap: 6           wget "${signature_url}"
2023-06-11T05:02:40.7358380Z + mkdir gnupg
2023-06-11T05:02:40.7364620Z + chmod 0700 gnupg
2023-06-11T05:02:40.7440180Z + popd
2023-06-11T05:02:40.7440690Z ~/work/buskill-app/buskill-app
2023-06-11T05:02:40.7441290Z + gpg --homedir /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg --import build/deps/python-gnupg.asc
2023-06-11T05:02:40.8382300Z gpg: keybox '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg/pubring.kbx' created
2023-06-11T05:02:40.8449770Z gpg: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg/trustdb.gpg: trustdb created
2023-06-11T05:02:40.8455760Z gpg: key 9147B477339A9B86: public key "Vinay Sajip (CODE SIGNING KEY) <vinay_sajip@yahoo.co.uk>" imported
2023-06-11T05:02:41.7729330Z gpg: Total number processed: 1
2023-06-11T05:02:41.7729630Z gpg:               imported: 1
2023-06-11T05:02:41.7742170Z + gpgv --homedir /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg --keyring /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg/pubring.kbx /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/python_gnupg-0.5.0-py2.py3-none-any.whl.asc /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/python_gnupg-0.5.0-py2.py3-none-any.whl
2023-06-11T05:02:41.8836140Z gpgv: can't allocate lock for '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/gnupg/pubring.kbx'
2023-06-11T05:02:41.8837960Z gpgv: can't open '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp.yc6FWCaL/python_gnupg-0.5.0-py2.py3-none-any.whl.asc': No such file or directory
2023-06-11T05:02:41.8839400Z gpgv: verify signatures failed: No such file or directory
2023-06-11T05:02:41.8840300Z + [[ 2 -ne 0 ]]
2023-06-11T05:02:41.8840670Z + echo 'ERROR: Invalid PGP signature!'
2023-06-11T05:02:41.8840890Z + exit 1
2023-06-11T05:02:41.8841080Z ERROR: Invalid PGP signature!
2023-06-11T05:02:41.8869760Z ##[error]Process completed with exit code 1.
2023-06-11T05:02:41.9038040Z Post job cleanup.
2023-06-11T05:02:42.0618060Z [command]/usr/local/bin/git version
2023-06-11T05:02:42.0772660Z git version 2.40.1
2023-06-11T05:02:42.0828120Z Copying '/Users/runner/.gitconfig' to '/Users/runner/work/_temp/f2c9bd0a-e6df-4105-8603-67b271715d31/.gitconfig'
2023-06-11T05:02:42.1257050Z Temporarily overriding HOME='/Users/runner/work/_temp/f2c9bd0a-e6df-4105-8603-67b271715d31' before making global git config changes
2023-06-11T05:02:42.1258630Z Adding repository directory to the temporary git global config as a safe directory
2023-06-11T05:02:42.1264560Z [command]/usr/local/bin/git config --global --add safe.directory /Users/runner/work/buskill-app/buskill-app
2023-06-11T05:02:42.1381480Z [command]/usr/local/bin/git config --local --name-only --get-regexp core\.sshCommand
2023-06-11T05:02:42.1481350Z [command]/usr/local/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2023-06-11T05:02:42.2564800Z [command]/usr/local/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2023-06-11T05:02:42.2642990Z http.https://github.com/.extraheader
2023-06-11T05:02:42.2656660Z [command]/usr/local/bin/git config --local --unset-all http.https://github.com/.extraheader
2023-06-11T05:02:42.2752130Z [command]/usr/local/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2023-06-11T05:02:42.5228380Z Cleaning up orphan processes
2023-06-11T05:02:42.5961610Z Terminate orphan process: pid (11353) (scdaemon)
2023-06-11T05:02:42.6060990Z Terminate orphan process: pid (11352) (gpg-agent)

[maltfield]

Looks like the problem here is the wget call on line 192 of the buildDmg.sh script

buskill-app/build/mac/buildDmg.sh

Lines 192 to 195 in 088e0af

	#wget "${signature_url}"
	# switching from wget to curl to avoid "dyld Library not loaded" brew issues
	# * https://github.com/BusKill/buskill-app/issues/70
	curl --remote-name "${signature_url}"

2023-06-11T05:02:40.6251680Z + wget https://files.pythonhosted.org/packages/83/e8/44c05b10888c907e8e327f17f257655a25a3ebe44772b77ef87b5fb336c2/python_gnupg-0.5.0-py2.py3-none-any.whl.asc
2023-06-11T05:02:40.7317270Z dyld[11344]: Library not loaded: '/usr/local/opt/libunistring/lib/libunistring.2.dylib'
2023-06-11T05:02:40.7319490Z   Referenced from: '/usr/local/Cellar/wget/1.20.3_2/bin/wget'
2023-06-11T05:02:40.7326580Z   Reason: tried: '/usr/local/opt/libunistring/lib/libunistring.2.dylib' (no such file), '/usr/local/lib/libunistring.2.dylib' (no such file), '/usr/lib/libunistring.2.dylib' (no such file), '/usr/local/Cellar/libunistring/1.1/lib/libunistring.2.dylib' (no such file), '/usr/local/lib/libunistring.2.dylib' (no such file), '/usr/lib/libunistring.2.dylib' (no such file)

Hmm...one says curl and one says wget. Oh, looks like this is something I already fixed in dev but I guess I haven't merged it up to this gui-shutdown-trigger branch yet

• Fix MacOS Builds (curl dyld Library not loaded for libunistring.2.dylib) #70

[maltfield]

Yep, merging from dev fixed it

• https://github.com/BusKill/buskill-app/actions/runs/5239515201