Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axios.create bug and bump versions to 1.2.11 #57

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

ViolanteCodes
Copy link
Contributor

@ViolanteCodes ViolanteCodes commented Apr 17, 2023

Fixes #55
Update version to 1.2.11, updates changelog, package.json

@courcelan
Copy link
Contributor

@ViolanteCodes this looks to run locally fine on the new version, no error message received with this PR.

ping me via internals so I can discuss with you how this propagates out. And whether we can follow recommendations on PR #56 to remove dist and to start tagging the release per Issue #51

Copy link
Contributor

@courcelan courcelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@courcelan
Copy link
Contributor

@ViolanteCodes this is good to go. updated based on #56 to update gitignore. when this is merged to master, please tag as 1.2.11 based on recommendation/request in #51

- Fix axios.create bug and bump versions to 1.2.11
- update examples to run on butter-js 1.2.11
- break out examples into duped tests dir for testing current version
- update build scripts, test scripts, remove dist dir and ignore
- remove dist dir and ignore per recommendation of #56
- update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - axios.create is not a function
2 participants