Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional sort function to columns #12

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

Buuntu
Copy link
Owner

@Buuntu Buuntu commented Aug 17, 2020

Should bump to a minor feature release.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #12 into master will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   96.20%   96.53%   +0.32%     
==========================================
  Files           4        4              
  Lines         158      173      +15     
  Branches       33       36       +3     
==========================================
+ Hits          152      167      +15     
  Misses          5        5              
  Partials        1        1              
Impacted Files Coverage Δ
src/hooks.tsx 95.58% <100.00%> (+0.23%) ⬆️
src/test/makeData.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f1b96...5fb9fbe. Read the comment docs.

…on to columns

The default sorting sorts by strings, however in the case where you have
more complex data such as dates, you may need to specify your own
sorting function
@Buuntu Buuntu force-pushed the gabud/add-date-and-array-sorting branch from e01744f to 5fb9fbe Compare August 17, 2020 21:25
@Buuntu Buuntu merged commit 43dc77e into master Aug 17, 2020
@Buuntu Buuntu deleted the gabud/add-date-and-array-sorting branch August 17, 2020 22:04
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants