Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates when maintaining history might cause too high memory use #119

Open
FabienRoger opened this issue Dec 15, 2021 · 1 comment
Open
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@FabienRoger
Copy link
Contributor

Currently, the SceneHistory saves around 50 snapshots of the current state of everything on screen, including images if I'm not mistaken.
If a notebook contains a two dozens of 2MB images, it could amount to 2.5GB of data in the history, which seems to high. For some users relying heavily on pictures, this might make the app usable.

This memory use could be drastically reduced if the app remembered deltas and not full snapshots.

@FabienRoger FabienRoger added enhancement New feature or request invalid This doesn't seem right labels Dec 15, 2021
@MathisFederico
Copy link
Member

You are right, we should just copy 'references' of images with a hash table or something like that so we don't have duplicates.
Also remembering 'deltas' is a very good idea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants