Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting a block out of focus loses the undo history of a block #27

Closed
AlexandreSajus opened this issue Nov 13, 2021 · 2 comments · Fixed by #118
Closed

Putting a block out of focus loses the undo history of a block #27

AlexandreSajus opened this issue Nov 13, 2021 · 2 comments · Fixed by #118
Assignees
Labels
bug Something isn't working

Comments

@AlexandreSajus
Copy link
Contributor

Currently, when a code block goes out of focus, it loses its undo history which means that pressing Ctrl+Z to undo its code does nothing. Ideally, the undo history should be saved per block. The user should be able to undo on a newly focused block.

@AlexandreSajus AlexandreSajus added the bug Something isn't working label Nov 13, 2021
@FabienRoger
Copy link
Contributor

I don't see a way to get the undo history to save it. QsciScintilla fundamental functions seem to work only with "Send", not with "Get"... It might be needed to override the undo function. I will try that if you have no other idea.

@FabienRoger FabienRoger self-assigned this Dec 14, 2021
@MathisFederico
Copy link
Member

I don't see a way to get the undo history to save it. QsciScintilla fundamental functions seem to work only with "Send", not with "Get"... It might be needed to override the undo function. I will try that if you have no other idea.

Yeah that's expected, we will need to overide their undo and to add a consistant buffer.

@FabienRoger FabienRoger linked a pull request Dec 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants