Skip to content

Commit

Permalink
properly isolate environment variable based tests into their own binary
Browse files Browse the repository at this point in the history 
Otherwise git invocations can fail if they see our marker values.
  • Loading branch information
@Byron
Byron committed Aug 21, 2023
1 parent 0d258f4 commit c35ddab
Show file tree
Hide file tree
Showing 2 changed files with 253 additions and 252 deletions.
253 changes: 253 additions & 0 deletions gix/tests/gix-init.rs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,253 @@
pub mod util;

mod with_overrides {
use std::borrow::Cow;

use gix_object::bstr::BStr;
use gix_sec::Permission;
use gix_testtools::Env;
use serial_test::serial;

use crate::util::named_subrepo_opts;

#[test]
#[serial]
fn order_from_api_and_cli_and_environment() -> gix_testtools::Result {
let default_date = "1979-02-26 18:30:00";
let _env = Env::new()
.set("GIT_HTTP_USER_AGENT", "agent-from-env")
.set("GIT_HTTP_LOW_SPEED_LIMIT", "1")
.set("GIT_HTTP_LOW_SPEED_TIME", "1")
.set("GIT_HTTP_PROXY_AUTHMETHOD", "proxy-auth-method-env")
.set("GIT_CURL_VERBOSE", "true")
.set("https_proxy", "https-lower-override")
.set("HTTPS_PROXY", "https-upper")
.set("http_proxy", "http-lower")
.set("all_proxy", "all-proxy-lower")
.set("ALL_PROXY", "all-proxy")
.set("no_proxy", "no-proxy-lower")
.set("NO_PROXY", "no-proxy")
.set("GIT_PROTOCOL_FROM_USER", "file-allowed")
.set("GIT_REPLACE_REF_BASE", "refs/replace-mine")
.set("GIT_NO_REPLACE_OBJECTS", "no-replace")
.set("GIT_COMMITTER_NAME", "committer name")
.set("GIT_COMMITTER_EMAIL", "committer email")
.set("GIT_COMMITTER_DATE", default_date)
.set("GIT_AUTHOR_NAME", "author name")
.set("GIT_AUTHOR_EMAIL", "author email")
.set("GIT_AUTHOR_DATE", default_date)
.set("EMAIL", "user email")
.set("GITOXIDE_PACK_CACHE_MEMORY", "0")
.set("GITOXIDE_OBJECT_CACHE_MEMORY", "5m")
.set("GIT_SSL_CAINFO", "./env.pem")
.set("GIT_SSL_VERSION", "tlsv1.3")
.set("GIT_SSH_VARIANT", "ssh-variant-env")
.set("GIT_SSH_COMMAND", "ssh-command-env")
.set("GIT_SSH", "ssh-command-fallback-env")
.set("GIT_LITERAL_PATHSPECS", "pathspecs-literal")
.set("GIT_GLOB_PATHSPECS", "pathspecs-glob")
.set("GIT_NOGLOB_PATHSPECS", "pathspecs-noglob")
.set("GIT_ICASE_PATHSPECS", "pathspecs-icase")
.set("GIT_SHALLOW_FILE", "shallow-file-env");
let mut opts = gix::open::Options::isolated()
.cli_overrides([
"http.userAgent=agent-from-cli",
"http.lowSpeedLimit=3",
"http.lowSpeedTime=3",
"http.sslCAInfo=./cli.pem",
"http.sslVersion=sslv3",
"ssh.variant=ssh-variant-cli",
"core.sshCommand=ssh-command-cli",
"gitoxide.ssh.commandWithoutShellFallback=ssh-command-fallback-cli",
"gitoxide.http.proxyAuthMethod=proxy-auth-method-cli",
"gitoxide.core.shallowFile=shallow-file-cli",
])
.config_overrides([
"http.userAgent=agent-from-api",
"http.lowSpeedLimit=2",
"http.lowSpeedTime=2",
"http.sslCAInfo=./api.pem",
"http.sslVersion=tlsv1",
"ssh.variant=ssh-variant-api",
"core.sshCommand=ssh-command-api",
"gitoxide.ssh.commandWithoutShellFallback=ssh-command-fallback-api",
"gitoxide.http.proxyAuthMethod=proxy-auth-method-api",
"gitoxide.core.shallowFile=shallow-file-api",
]);
opts.permissions.env.git_prefix = Permission::Allow;
opts.permissions.env.http_transport = Permission::Allow;
opts.permissions.env.identity = Permission::Allow;
opts.permissions.env.objects = Permission::Allow;
let repo = named_subrepo_opts("make_config_repos.sh", "http-config", opts)?;
assert_eq!(
repo.config_snapshot().meta().source,
gix::config::Source::Local,
"config always refers to the local one for safety"
);
let config = repo.config_snapshot();
assert_eq!(
config
.strings_by_key("gitoxide.core.shallowFile")
.expect("at least one value"),
[
cow_bstr("shallow-file-cli"),
cow_bstr("shallow-file-api"),
cow_bstr("shallow-file-env")
]
);
assert_eq!(
config.strings_by_key("http.userAgent").expect("at least one value"),
[
cow_bstr("agentJustForHttp"),
cow_bstr("agent-from-cli"),
cow_bstr("agent-from-api"),
cow_bstr("agent-from-env")
]
);
assert_eq!(
config
.integers_by_key("http.lowSpeedLimit")
.transpose()?
.expect("many values"),
[5120, 3, 2, 1]
);
assert_eq!(
config
.integers_by_key("http.lowSpeedTime")
.transpose()?
.expect("many values"),
[10, 3, 2, 1]
);
assert_eq!(
config
.strings_by_key("http.proxyAuthMethod")
.expect("at least one value"),
[cow_bstr("basic")],
"this value isn't overridden directly"
);
assert_eq!(
config
.strings_by_key("gitoxide.https.proxy")
.expect("at least one value"),
[
cow_bstr("https-upper"),
cow_bstr(if cfg!(windows) {
"https-upper" // on windows, environment variables are case-insensitive
} else {
"https-lower-override"
})
]
);
assert_eq!(
config
.strings_by_key("gitoxide.http.proxy")
.expect("at least one value"),
[cow_bstr("http-lower")]
);
assert_eq!(
config
.strings_by_key("gitoxide.http.allProxy")
.expect("at least one value"),
[
cow_bstr("all-proxy"), // on windows, environment variables are case-insensitive
cow_bstr(if cfg!(windows) { "all-proxy" } else { "all-proxy-lower" })
]
);
assert_eq!(
config
.strings_by_key("gitoxide.http.noProxy")
.expect("at least one value"),
[
cow_bstr("no-proxy"), // on windows, environment variables are case-insensitive
cow_bstr(if cfg!(windows) { "no-proxy" } else { "no-proxy-lower" })
]
);
assert_eq!(
config.strings_by_key("http.sslCAInfo").expect("at least one value"),
[
cow_bstr("./CA.pem"),
cow_bstr("./cli.pem"),
cow_bstr("./api.pem"),
cow_bstr("./env.pem")
]
);
assert_eq!(
config.strings_by_key("http.sslVersion").expect("at least one value"),
[
cow_bstr("sslv2"),
cow_bstr("sslv3"),
cow_bstr("tlsv1"),
cow_bstr("tlsv1.3")
]
);
assert_eq!(
config.strings_by_key("ssh.variant").expect("at least one value"),
[
cow_bstr("ssh-variant-cli"),
cow_bstr("ssh-variant-api"),
cow_bstr("ssh-variant-env"),
]
);
assert_eq!(
config.strings_by_key("core.sshCommand").expect("at least one value"),
[
cow_bstr("ssh-command-cli"),
cow_bstr("ssh-command-api"),
cow_bstr("ssh-command-env"),
]
);
assert_eq!(
config
.strings_by_key("gitoxide.ssh.commandWithoutShellFallback")
.expect("at least one value"),
[
cow_bstr("ssh-command-fallback-cli"),
cow_bstr("ssh-command-fallback-api"),
cow_bstr("ssh-command-fallback-env"),
]
);
assert_eq!(
config
.strings_by_key("gitoxide.http.proxyAuthMethod")
.expect("at least one value"),
[
cow_bstr("proxy-auth-method-cli"),
cow_bstr("proxy-auth-method-api"),
cow_bstr("proxy-auth-method-env"),
]
);
for (key, expected) in [
("gitoxide.http.verbose", "true"),
("gitoxide.allow.protocolFromUser", "file-allowed"),
("core.useReplaceRefs", "no-replace"),
("gitoxide.objects.replaceRefBase", "refs/replace-mine"),
("gitoxide.committer.nameFallback", "committer name"),
("gitoxide.committer.emailFallback", "committer email"),
("gitoxide.author.nameFallback", "author name"),
("gitoxide.author.emailFallback", "author email"),
("gitoxide.commit.authorDate", default_date),
("gitoxide.commit.committerDate", default_date),
("gitoxide.user.emailFallback", "user email"),
("core.deltaBaseCacheLimit", "0"),
("gitoxide.objects.cacheLimit", "5m"),
("gitoxide.pathspec.icase", "pathspecs-icase"),
("gitoxide.pathspec.glob", "pathspecs-glob"),
("gitoxide.pathspec.noglob", "pathspecs-noglob"),
("gitoxide.pathspec.literal", "pathspecs-literal"),
] {
assert_eq!(
config
.string_by_key(key)
.unwrap_or_else(|| panic!("no value for {key}"))
.as_ref(),
expected,
"{key} == {expected}"
);
}
Ok(())
}

fn cow_bstr(s: &str) -> Cow<BStr> {
Cow::Borrowed(s.into())
}
}
Loading

0 comments on commit c35ddab

Please sign in to comment.