Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project non Version format of LangVersion fails to build #21

Closed
ByronMayne opened this issue Jul 24, 2024 · 0 comments · Fixed by #23
Closed

Project non Version format of LangVersion fails to build #21

ByronMayne opened this issue Jul 24, 2024 · 0 comments · Fixed by #23
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ByronMayne
Copy link
Owner

Description:
There is currently an error that is generated if the project is targeting an older version of the language. It currently is this

 <Error
   Condition="$([MSBuild]::VersionGreaterThan('$(MinLangVersion)', '$(LangVersion)'))"
   Text="[SourceGenerator.Foundations] The project $(MSBuildProjectName) is currently using the language version $(LangVersion) which does not meet the minimum required of $(MinLangVersion). Read how to change it here https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version" />

The problem is there are validate values for Version that are not number, if this is used there is an build exception.

  • preview
  • latest
  • latestMajor
  • default
  • ISO-2
  • ISO-1

We should update the error to account for these values

@ByronMayne ByronMayne added bug Something isn't working good first issue Good for newcomers labels Jul 24, 2024
@ByronMayne ByronMayne self-assigned this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant