This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
add vaildate-block #1815
Merged
add vaildate-block #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenao78
reviewed
Nov 29, 2019
protocol/validation/tx.go
Outdated
| } | ||
|
|
||
| func validateTxWorker(workCh chan *validateTxWork, resultCh chan *ValidateTxResult, closeCh chan struct{}, wg *sync.WaitGroup) { | ||
| for { |
There was a problem hiding this comment.
我记得直接可以使用for对workCh遍历，外部只要close workCh就可以退出循环了。这样可以不要不用搞个closeCh出来了
shenao78
reviewed
Nov 29, 2019
protocol/validation/tx.go
Outdated
| close(closeCh) | ||
| wg.Wait() | ||
| close(workCh) | ||
| close(resultCh) |
There was a problem hiding this comment.
如果没有正式的目的，channel不需要关闭
https://stackoverflow.com/questions/8593645/is-it-ok-to-leave-a-channel-open
shenao78
approved these changes
Nov 29, 2019
0xmountaintop
approved these changes
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.