Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in records.go #15

Closed
yoav-orca opened this issue May 2, 2021 · 1 comment
Closed

Small bug in records.go #15

yoav-orca opened this issue May 2, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@yoav-orca
Copy link
Contributor

I wanted to switch to use gosecretsdump and I have a script that parses the output for impact, I found a small bug:

if v, err := record.StrVal(nuserPrincipalName); err != nil && v != "" && strings.Contains(v, "@") { //record.Column[nuserPrincipalName"]].StrVal; v != "" {

It should be err == nil and not err != nil

@C-Sto C-Sto added the bug Something isn't working label May 3, 2021
@C-Sto C-Sto self-assigned this May 3, 2021
@C-Sto C-Sto closed this as completed in 09746b5 May 3, 2021
@C-Sto
Copy link
Owner

C-Sto commented May 3, 2021

well spotted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants