-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xy(z) profiler] steps plot #92
Comments
agreed, the steps should be centred on the pixel values, to make them consistent with our plot |
@kswang1029 I will work on a feature for the ChartJS library and issue a PR to that repo, hopefully it will get merged in quickly. |
Ok thanks for fixing this. |
PR to the Chart.JS library has been submitted. It might take some time to be merged into the master branch and released, so if this is an urgent fix, we will need to manually use the updated build (requires a bit of re-configuration). @kswang1029 thoughts? |
I suggest we wait and mark this as known issue for v1.0-rel. Should be less critical to UX I think. |
@kswang1029 turns out it was very easy to use the updated build, so I've issued a PR (#110). Can you have a look at dev-viewer to confirm if it looks ok? |
it looks GREAT! |
In the xyz profile plots, it seems that the step is aligned to the left edge, not center. Naively aligning to the center is better. Any thoughts?
The text was updated successfully, but these errors were encountered: