Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy(z) profiler] steps plot #92

Closed
kswang1029 opened this issue Dec 5, 2018 · 7 comments
Closed

[xy(z) profiler] steps plot #92

kswang1029 opened this issue Dec 5, 2018 · 7 comments
Assignees
Labels
blocked For issues that are blocked, either by other issues, or by external dependencies enhancement New feature or request

Comments

@kswang1029
Copy link
Collaborator

In the xyz profile plots, it seems that the step is aligned to the left edge, not center. Naively aligning to the center is better. Any thoughts?

screen shot 2018-12-05 at 3 25 59 pm

@veggiesaurus
Copy link
Collaborator

agreed, the steps should be centred on the pixel values, to make them consistent with our plot

@veggiesaurus veggiesaurus self-assigned this Dec 5, 2018
@veggiesaurus
Copy link
Collaborator

@kswang1029 I will work on a feature for the ChartJS library and issue a PR to that repo, hopefully it will get merged in quickly.

@kswang1029
Copy link
Collaborator Author

Ok thanks for fixing this.

@veggiesaurus veggiesaurus added the enhancement New feature or request label Dec 12, 2018
@veggiesaurus
Copy link
Collaborator

PR to the Chart.JS library has been submitted. It might take some time to be merged into the master branch and released, so if this is an urgent fix, we will need to manually use the updated build (requires a bit of re-configuration). @kswang1029 thoughts?

@kswang1029
Copy link
Collaborator Author

I suggest we wait and mark this as known issue for v1.0-rel. Should be less critical to UX I think.

@veggiesaurus veggiesaurus added the blocked For issues that are blocked, either by other issues, or by external dependencies label Dec 12, 2018
@veggiesaurus veggiesaurus added this to the Post-V1.0 milestone Dec 12, 2018
veggiesaurus added a commit that referenced this issue Dec 12, 2018
@veggiesaurus
Copy link
Collaborator

@kswang1029 turns out it was very easy to use the updated build, so I've issued a PR (#110). Can you have a look at dev-viewer to confirm if it looks ok?

@kswang1029
Copy link
Collaborator Author

it looks GREAT!

veggiesaurus added a commit that referenced this issue Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked For issues that are blocked, either by other issues, or by external dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants