feat: allow multiallelic variants in transform
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlamkin7 , can you review this? and just double check that the tests are sufficient? also, can you recall any other reason we hadn't enabled support for biallelic variants in |
aryarm
changed the title
transformtransform
mlamkin7
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making this PR for @XimeiWulilyy , who asked recently about whether the
transformcommand could accept multiallelic SNPs. Previously, there was a check in place to restrict it to only biallelic variants, since theGenotypesVCFclass could handle only biallelic variants. But then multiallelic support was added to theGenotypesVCFclass in #195.This PR removes the biallelic check in
transform, adds some tests, and makes some changes toHaplotype.transformandHaplotypes.transformto allow them to handleGenotypesclasses with multiallelic variants in them.