Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scrollbar on Labels Filter bar when not needed #17

Closed
gycgabriel opened this issue Jul 11, 2022 · 3 comments
Closed

Remove scrollbar on Labels Filter bar when not needed #17

gycgabriel opened this issue Jul 11, 2022 · 3 comments
Assignees
Labels
aspect-UIX difficulty.Moderate can be done after you have done a few easy issues first

Comments

@gycgabriel
Copy link
Collaborator

gycgabriel commented Jul 11, 2022

Describe the bug
The labels filter bar shows a scrollbar even when there is nothing to scroll below.
I've tried resizing the html components surrounding it, but the scrollbar is displayed even when set to auto.

Expected behavior
The scrollbar should only be displayed if there are so many labels selected to be filtered that it overflows.

Screenshots
image

@kkangs0226 kkangs0226 added aspect-UIX difficulty.Moderate can be done after you have done a few easy issues first labels Jan 12, 2023
@seetohjinwei
Copy link
Contributor

Hi! I think this issue might have been fixed already, as I cannot reproduce it.

However, I noticed that

  • a repository with no issues still displays a fixed height container
  • a repository with many issues is scrollable, but there is no scroll bar
    • this seems to be intentional based on the CSS, but I feel like this might lead to the user being unaware that the container is scrollable

Currently

Repository with many labels:

image

Repository with no labels:

image

Proposed Change

  • Change height: 400px to max-height: 400px
  • Allow the scrollbar to be visible when there is content to be scrolled

image

@Eclipse-Dominator
Copy link
Contributor

Sounds good, lets make this in a separate issue and close this one

@NereusWB922
Copy link
Contributor

Issue solved by #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect-UIX difficulty.Moderate can be done after you have done a few easy issues first
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants