Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test cases for Label Service #258

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Refactor test cases for Label Service #258

merged 3 commits into from
Feb 26, 2024

Conversation

NereusWB922
Copy link
Contributor

@NereusWB922 NereusWB922 commented Feb 19, 2024 •
edited
Loading

Summary:

Fixes part of #85

Type of change:

  • 🧪 Tests Update

Changes Made:

  • Refactor test cases for label service
  • Add test case for fetchLabels()

Proposed Commit Message:

Refactor test cases for label service

The test cases for the label service are outdated. 

Let's refactor the test cases for the label service and
add test case for fetchLabels method.

luminousleek
luminousleek requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@luminousleek luminousleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, but there's some changes that need to be made.

tests/services/label.service.spec.ts Show resolved Hide resolved
tests/services/label.service.spec.ts Outdated Show resolved Hide resolved
@NereusWB922 NereusWB922 force-pushed the 85-refactor-tests-label-service branch from 46c26e7 to e26565a Compare February 20, 2024 04:51
@NereusWB922 NereusWB922 force-pushed the 85-refactor-tests-label-service branch from 80a6f4f to 6c4f77f Compare February 22, 2024 09:08
luminousleek
luminousleek approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@luminousleek luminousleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NereusWB922 NereusWB922 force-pushed the 85-refactor-tests-label-service branch from 6c4f77f to 55d5f71 Compare February 26, 2024 04:56
@NereusWB922 NereusWB922 merged commit 2c36a38 into CATcher-org:main Feb 26, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the 85-refactor-tests-label-service branch February 26, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luminousleek luminousleek luminousleek approved these changes

@nknguyenhc nknguyenhc Awaiting requested review from nknguyenhc

Assignees
No one assigned
Labels
s.toReview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NereusWB922 @luminousleek