Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax pyarrow version requirements? #116

Open
jefferis opened this issue Aug 24, 2023 · 2 comments
Open

relax pyarrow version requirements? #116

jefferis opened this issue Aug 24, 2023 · 2 comments

Comments

@jefferis
Copy link

can we allow pyarrow>=12 now?
https://github.com/seung-lab/CAVEclient/blob/7fbc0e20c3b42236989e4f103411454b92111b81/requirements.txt#L2

It would require additional logic for the deserialize step here (to check the version of pyarrow / if pa.deserialize is available) :

https://github.com/seung-lab/CAVEclient/blob/7fbc0e20c3b42236989e4f103411454b92111b81/caveclient/materializationengine.py#L41

so perhaps you don't want to do it yet.

@ceesem
Copy link
Collaborator

ceesem commented Aug 24, 2023

The logic is already in there to not use the older pyarrow code path if you don't need to — if both the server and the client are running up to date versions, everything should be compatible with the more recent versions of pyarrow. However, we haven't fully tested it in that situation, and more importantly we also wanted to make sure that there is a period where we keep things overlapping with a warning while some projects we know of (not the ones managed by us) have not yet updated their materialization server.

If you want to try to force upgrade pyarrow beyond 12 in your own environment, we think it should work (and we should make sure of that as well).

@jefferis
Copy link
Author

jefferis commented Aug 25, 2023

Thanks @ceesem. Yes forcing pyarrow to 12 is what I am currently doing. The reason I care is that I see crashes in R when running a separate R arrow-based process for those with different pyarrow and R arrow major versions. I haven't tracked down why but right now force upgrading pyarrow is the only solution I can find. Arrow 11 displays a different bug with querying feather files on disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants