Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Disposable Launchers to be replaced in Backpacks #1356

Closed
Eogos opened this issue Jul 13, 2020 · 14 comments
Closed

Allow Disposable Launchers to be replaced in Backpacks #1356

Eogos opened this issue Jul 13, 2020 · 14 comments

Comments

@Eogos
Copy link

Eogos commented Jul 13, 2020

Is your enhancement related to a problem?
Currently the Disposable Launcher system, when active, replaces instances of the ammo with the disposable launcher it goes to, however backpacks are excluded from this and only have the ammo removed but no corresponding launcher added to replace the now removed ammo. This can lead to instances of scenarios designed with a certain amount of AT in mind being harder due to missing AT launchers depending on the settings of the host.

Solution you'd like:
Ammo in backpacks should be handled the same as every other container and have the ammo directly replaced with disposable launchers rather than just removed.

Alternatives you've considered:
Not replacing ammo with launchers anywhere, for consistency.

Additional context:
This came up after discussion on the CUP discord where it was learned that backpacks are specifically excluded for some unknown reason and a request to make an issue report was made. To me and some others, it does not make sense to exclude backpacks from the replacement process specifically when it is still done everywhere else.

@commy2
Copy link
Contributor

commy2 commented Jul 13, 2020

By "instances of the ammo" and "Ammo in backpacks", you mean the loaded launcher classes?

@Drofseh
Copy link
Contributor

Drofseh commented Jul 13, 2020

The idea is that a rocket should get turned into a rocket launcher, regardless of what container it's in.

@Eogos
Copy link
Author

Eogos commented Jul 13, 2020

The idea is that a rocket should get turned into a rocket launcher, regardless of what container it's in.

This is what I mean.

@commy2
Copy link
Contributor

commy2 commented Jul 14, 2020

No, magazines should not turn into launchers.

@Drofseh
Copy link
Contributor

Drofseh commented Jul 14, 2020

They do though, everywhere except backpacks.

This means that if a mod or mission maker gives a unit a launcher and an additional magazine in their backpack (2 shots total) then when played with CBA the extra magazine gets deleted but not replaced, so the unit now has only a single shot.

The contention is that magazines in backpacks ought to be replaced with a launcher in the same manner as magazines that are in any other container.

@dedmen
Copy link
Contributor

dedmen commented Jul 14, 2020

Never knew that they get replaced.. because I usually only have the ammo in backpack. Why would anyone put launcher ammo in uniform or vest anyway, isn't it a bit too big for that 🤔

@jonpas
Copy link
Member

jonpas commented Jul 14, 2020

No it isn't. There are various smaller disposable launchers.

@bux
Copy link
Contributor

bux commented Jul 14, 2020

There are various smaller disposable launchers.

image

@commy2
Copy link
Contributor

commy2 commented Jul 14, 2020

I think I get what you mean. We're talking about containers, where magazines are replaced with loaded launchers. And these loaded launchers decay into a launcher + magazine on Take.

@dedmen
Copy link
Contributor

dedmen commented Jul 17, 2020

We're talking about containers, where magazines are replaced with loaded launchers. And these loaded launchers decay into a launcher + magazine on Take.

yes and no.

We're talking about containers, where magazines are replaced with loaded launchers.

That happens in uniform and vest, but not in backpack, thats the problem. And backpack was for some reason specifically disabled.

@commy2
Copy link
Contributor

commy2 commented Jul 17, 2020

Because the backpack can hold the magazines in vanilla, and I don't want to have base game AT soldiers/ Ammo carries with 4+ launchers in their backpack walking around.

The init script is to mass replace magazines in equipment boxes with loaded launchers. It is meant to exclude backpacks, and all other unit containers as well, it is just that those don't run init scripts anyway and don't contain any launcher magazines due to them being generally incompatible with anything but backpacks.

If you want your soldier to have extra launcher in the backpack, configure them so they have loaded launchers in the backpack.

@10Dozen
Copy link
Contributor

10Dozen commented Jul 17, 2020

Sorry if that was already disccussed.

can hold the magazines in vanilla

What about adding extra config property that allows specific magazine to be converted into the launcher in any conditions?
For NLAW mags it will be considered as false (by default), and it prevent massive disposal launchers from appearing in the backpacks.
For RPG-18/LAW mags property will be true and all mags will be replaced with launcher everywhere.

@commy2
Copy link
Contributor

commy2 commented Jul 18, 2020

I am fine with that.

@commy2
Copy link
Contributor

commy2 commented Jun 5, 2021

I am open to pull requests on this, but Disposable is a port from BWA3 and we have no use for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants