Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposables - Add functionality to require CLU attached to tubes in order to fire #1371

Closed
Freddo3000 opened this issue Sep 8, 2020 · 9 comments

Comments

@Freddo3000
Copy link
Contributor

Is your enhancement related to a problem?
Lots of launchers use a system where the CLU (Command Launch Unit) is reusable, and the tube is disposed of. Right now you're limited to either having magazines stored in the backpack, which isn't particularly realistic or making the entire assembled launcher disposable.

Examples:

  • FGM-148 Javelin
  • FIM-92 Stinger
  • 9K38 Igla
  • Panzerfaust 3
  • etc

Solution you'd like:
Add functionality to require a CLU attachment (scope, attachment, bipod, whatever) before being able to select the launcher, and adding the hidden disposable magazine. Possibly also add an option to play an animation when attaching the optic/attachment.

Additionally for weapons that use this configuration, replace the old magazines with a tube lacking CLU and old weapons with a tube with CLU.

Alternatives you've considered:
N/A

@commy2
Copy link
Contributor

commy2 commented Sep 9, 2020

No.

@Freddo3000
Copy link
Contributor Author

Freddo3000 commented Sep 9, 2020

No.

Why not?

@commy2
Copy link
Contributor

commy2 commented Sep 10, 2020

Because this is a port of what I made for BWA3, similar to the scripted optics, and was moved under the condition that it does not get expanded endlessly.

Close?

@Freddo3000
Copy link
Contributor Author

Because this is a port of what I made for BWA3, similar to the scripted optics, and was moved under the condition that it does not get expanded endlessly.

Close?

Where is that even written? I'm not seeing it on the pull requests #1105 or #1116.
Its fine if you don't want to make it yourself but just saying straight up no to stuff seems to go against the community-based spirit of this project, especially if it's for arbitrary reasons like this.

@jonpas
Copy link
Member

jonpas commented Sep 17, 2020

This seems in-scope to me. The easiest way to implement this without expanding CBA with specific things is providing the ability for the developer to specify his own conditions, which would get evaluated on trigger press.

Because this is a port of what I made for BWA3, similar to the scripted optics, and was moved under the condition that it does not get expanded endlessly.

There is no such condition, CBA does not get things "under conditions". I assume @commy2 means he will not do it himself, which is fine.

@commy2
Copy link
Contributor

commy2 commented Oct 3, 2020

No one is picking this up after 2 weeks. Close?

Edit:
This is never going to happen realistically. You should ask on Slack before opening futile requests. Maybe you can find a contributor that can create a pull request.

@Freddo3000
Copy link
Contributor Author

Is there a CBA slack?

@commy2
Copy link
Contributor

commy2 commented Oct 4, 2020

#cba channel on the ACE public Slack.

@commy2
Copy link
Contributor

commy2 commented Jun 5, 2021

I am open to pull requests on this, but Disposable is a port from BWA3 and we have no use for this.

@commy2 commy2 closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants