Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBA_common_fnc_getGroup - toLower instead of toUpper #176

Closed
Dorbedo opened this issue Oct 10, 2015 · 4 comments
Closed

CBA_common_fnc_getGroup - toLower instead of toUpper #176

Dorbedo opened this issue Oct 10, 2015 · 4 comments
Labels
Bug
Milestone
2.1.2

Comments

@Dorbedo
Copy link
Contributor

Dorbedo commented Oct 10, 2015

wrong command in CBA_common_fnc_getGroup

Line 23
Is:
if (tolower (typeName _this) == "GROUP") exitwith {_this};

should be:
if (toUpper (typeName _this) == "GROUP") exitwith {_this};

or maybe:
if (toUpper (typeName _this) isEqualTo "GROUP") exitwith {_this};
@shadez95
Copy link
Contributor

should isEqualTo be used since it's faster?

@jonpas
Copy link
Member

jonpas commented Oct 10, 2015

Preferably yes.

@Dorbedo
Copy link
Contributor Author

Dorbedo commented Oct 10, 2015

This was my proposal.

@Killswitch00
Copy link
Contributor

Fixed in eb6eae8

@Killswitch00 Killswitch00 modified the milestones: 2.2, 2.1.2 Oct 11, 2015
@Dorbedo Dorbedo mentioned this issue Oct 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
4 participants
@jonpas @shadez95 @Dorbedo @Killswitch00