Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected dependency on A3_Ui_F_Data added to cba_ui #346

Closed
Killswitch00 opened this issue May 31, 2016 · 4 comments
Closed

Unexpected dependency on A3_Ui_F_Data added to cba_ui #346

Killswitch00 opened this issue May 31, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@Killswitch00
Copy link
Contributor

The 2.4.0.160530 cba_ui.pbo has a dependency on A3_Ui_F_Data that is not there in the source file. This causes problems with the 1.54 Linux/MacOS ports - "A3_Ui_F_Data" is a new thing for A3 v1.60.

Possible build issue.

@Killswitch00 Killswitch00 added this to the 2.4.1 milestone May 31, 2016
@PabstMirror
Copy link
Contributor

open pboPrject -> setup -> uncheck setting and close pboProject
make.py will build with that setting

image

@commy2
Copy link
Contributor

commy2 commented Jun 1, 2016

I wonder why the tools add this as requirement. With or without it there are no UBC warnings. And A3_Ui_F_Data doesn't even have a config besides CfgPatches.

@Killswitch00
Copy link
Contributor Author

Killswitch00 commented Jun 1, 2016

Technically, cba_ui should depend on A3_Ui_F (cba_ui references RscText and RscShortcutButton which are, as far as I can tell, defined in A3_Ui_F (aka ui_f.pbo). As to why proProject adds A3_Ui_F_Data could be because that addon (in 1.60) depends on A3_Ui_F, which is backwards - it is the config in ui_f.pbo that references files in ui_f_data.pbo.

What happens if we add A3_Ui_F to the list of dependencies in cba_ui.pbo and run pboProject with "rebuild requiredAddons[]=" checked? Would it still rewrite requiredAddons in cba_ui?

@Killswitch00 Killswitch00 changed the title Stray dependency on A3_Ui_F_Data in cba_ui Unexpected dependency on A3_Ui_F_Data added to cba_ui Jun 1, 2016
@ViperMaul
Copy link
Contributor

"What happens if we add A3_UI_F to the list of dependencies in cba_ui.pbo and run pboProject" @Killswitch00

Here is the response from MikeRo, creator of pboProject:
"Let them know that, as per the readme, pboProject will honor any hard-wired dependencies pre-stated in requiredaddons." -MikeRo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants