Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save only changed settings into mission #850

Closed
jonpas opened this issue Dec 25, 2017 · 3 comments · Fixed by #853
Closed

Save only changed settings into mission #850

jonpas opened this issue Dec 25, 2017 · 3 comments · Fixed by #853

Comments

@jonpas
Copy link
Member

jonpas commented Dec 25, 2017

Arma 3 Version: 1.80 (stable)
CBA Version: 3.5.0 (stable)

Mods:

- CBA_A3
- ace
- acex
- acre
- tac_mods
- NIArms
- A few more without CBA Settings

Description:

  • Currently Settings save all settings into mission.sqm, even those that are untouched/default, resulting in about 200 KB size increase (~12.800 lines) with above mods.
  • Major improvement would be to only save changed settings.
  • Possibly also happens when saving to profile (client or server), but that was not verified.

Steps to reproduce:

  • Check mission.sqm size or line count
  • Save settings in mission
  • Check mission.sqm size or line count

Where did the issue occur?

  • Editor (Singleplayer)

RPT log file:

  • N/A
@jonpas jonpas added this to the 3.6 milestone Dec 25, 2017
@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

It does only save changed settings. What happens is, that all global flag settings are recognized as changed from the default, because they have the priority set to 1 instead of 0.

@jonpas
Copy link
Member Author

jonpas commented Dec 26, 2017

I see, so it's actually a bug?

@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

Kind of. It doesn't break anything functionally, but the original intention was to only store changed settings (incl. priority), which got broken during development when global settings were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants