Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBA_fnc_waitUntilAndExecute should accept 0 as timeout #910

Closed
felixlinker opened this issue Apr 20, 2018 · 3 comments
Closed

CBA_fnc_waitUntilAndExecute should accept 0 as timeout #910

felixlinker opened this issue Apr 20, 2018 · 3 comments
Milestone

Comments

@felixlinker
Copy link
Contributor

Hi there,

I think CBA_fnc_waitUntilAndExecute would behave more intuitively if the value for no timeout would be -1 or something else truly less than zero.
In my case there is a timeout that might resolve to zero and in this case I would expect CBA_fnc_waitUntilAndExecute to execute the code immediately.

Right now, it treats a zero as if no timeout was given: https://github.com/CBATeam/CBA_A3/blob/master/addons/common/fnc_waitUntilAndExecute.sqf#L40

@commy2
Copy link
Contributor

commy2 commented Apr 20, 2018

You mean it should execute the timeout code next frame if timeout was set to 0 explicitly?

@felixlinker
Copy link
Contributor Author

Or just immediately.

@felixlinker
Copy link
Contributor Author

This is what I think would be better.

@commy2 commy2 closed this as completed Apr 29, 2018
@commy2 commy2 added this to the 3.7 milestone Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants