Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerfusionAlignment Fixes #1310

Merged
merged 79 commits into from
Sep 28, 2020
Merged

PerfusionAlignment Fixes #1310

merged 79 commits into from
Sep 28, 2020

Conversation

sarthakpati
Copy link
Contributor

@sarthakpati sarthakpati commented Sep 16, 2020 •
edited
Loading

Fixes issue #1235

Proposed Changes

Other changes (not accessible by user):

  • single 4D perfusion image getting written
  • T1CE is no longer needed (both CLI and GUI)
  • updated documentation (removed RAM requirement because my laptop with 16GB RAM was able to align even a full-sized Perfusion image without memory usage reaching more than 60%)
  • includes 1305 #1306

@sarthakpati sarthakpati marked this pull request as draft September 16, 2020 22:19
@sarthakpati
Copy link
Contributor Author

Artifacts (CLI-only): https://dev.azure.com/CBICA/CaPTk/_build/results?buildId=2362&view=artifacts&type=publishedArtifacts

@sarthakpati sarthakpati marked this pull request as ready for review September 17, 2020 12:42
@sarthakpati sarthakpati marked this pull request as draft September 17, 2020 12:42
@sarthakpati sarthakpati changed the title 1235 PerfusionAlignment Fixes Sep 17, 2020
@sarthakpati sarthakpati marked this pull request as ready for review September 24, 2020 12:06
@sarthakpati sarthakpati marked this pull request as draft September 24, 2020 16:57
@sarthakpati sarthakpati marked this pull request as ready for review September 25, 2020 01:19
@sarthakpati sarthakpati mentioned this pull request Sep 25, 2020
Closed
@sarthakpati
Copy link
Contributor Author

@CBICA/devteam: this is ready for review.

@ashishsingh18 ashishsingh18 merged commit 6058f84 into CBICA:master Sep 28, 2020
@sarthakpati sarthakpati deleted the 1235 branch September 28, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGetka-cbica AlexanderGetka-cbica AlexanderGetka-cbica approved these changes

@ashishsingh18 ashishsingh18 ashishsingh18 approved these changes

@saimarathore saimarathore Awaiting requested review from saimarathore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarthakpati @ashishsingh18 @AlexanderGetka-cbica @saimarathore