Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working directory to solve #2 #3

Merged
merged 28 commits into from
Aug 29, 2024
Merged

Conversation

spirosmaggioros
Copy link
Member

  • Task 7 Completed: Updated sbmodules with their latest versions

Some submodules were outdated and were not being cloned with the typical update command
@spirosmaggioros spirosmaggioros added documentation Improvements or additions to documentation enhancement New feature or request Installation Bugs depending installation issues labels Aug 20, 2024
@spirosmaggioros spirosmaggioros added this to the Unification milestone Aug 20, 2024
@spirosmaggioros spirosmaggioros self-assigned this Aug 20, 2024
@spirosmaggioros spirosmaggioros linked an issue Aug 20, 2024 that may be closed by this pull request
@spirosmaggioros spirosmaggioros marked this pull request as draft August 20, 2024 08:26
@gurayerus
Copy link
Collaborator

Hi Spiros, I found why it fails in combat step. The bash script "util_combat_test.sh" calls "out_csv=$(realpath $3)"; when the output folder does not exist, realpath may fail depending on OS/shell . For now, it can be fixed by: "out_csv=$3"

@spirosmaggioros spirosmaggioros marked this pull request as ready for review August 29, 2024 05:35
@spirosmaggioros spirosmaggioros merged commit 428fbc5 into CBICA:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Installation Bugs depending installation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unification of NiChart
4 participants