-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Orchid #52
Comments
Still needs a patch update but update to 3 is done |
Hello World! I love Orchid! |
I updated to 3.1.1 and made small changes for functionality, but I haven't gone through an indepth review of the various changes to templates yet. |
I noticed that this change in Orchid hasn't been incorporated: https://github.com/CDRH/orchid/blob/dev/app/views/items/_search_res_items.html.erb#L1 This makes me think we should probably note all template changes in Orchid in our changelog notes between versions to greatly simplify incorporating said changes in overrides elsewhere. It'll be more documentation on the Orchid side, but much easier for updating overrides in other Rails apps. Things like this are also why we try to target overrides as narrowly as possible. Sometimes it becomes apparent we need to break down some of these templates into more partials. Might be the case we'll want to do that for the individual item type displays in search results here in the future 👍 |
Use the latest release and review templates copied from it in the past for customization to include upstream changes
The text was updated successfully, but these errors were encountered: