Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Orchid #52

Open
techgique opened this issue Apr 2, 2020 · 4 comments
Open

Update Orchid #52

techgique opened this issue Apr 2, 2020 · 4 comments
Labels
close? review then close in the news stuff relevant for African Poets in the News
Milestone

Comments

@techgique
Copy link
Member

Use the latest release and review templates copied from it in the past for customization to include upstream changes

@techgique techgique added the in the news stuff relevant for African Poets in the News label Apr 2, 2020
@karindalziel karindalziel added the close? review then close label Oct 16, 2020
@karindalziel karindalziel added this to the Other milestone Oct 20, 2020
@karindalziel karindalziel removed the close? review then close label Dec 17, 2020
@karindalziel
Copy link
Member

Still needs a patch update but update to 3 is done

@BorsaMetin
Copy link

Hello World!

I love Orchid!

@jduss4
Copy link
Contributor

jduss4 commented Jan 13, 2021

I updated to 3.1.1 and made small changes for functionality, but I haven't gone through an indepth review of the various changes to templates yet.

@techgique
Copy link
Member Author

techgique commented Oct 5, 2022

I noticed that this change in Orchid hasn't been incorporated: https://github.com/CDRH/orchid/blob/dev/app/views/items/_search_res_items.html.erb#L1
in the override here: https://github.com/CDRH/african_poetics/blob/main/app/views/items/_search_res_items.html.erb

This makes me think we should probably note all template changes in Orchid in our changelog notes between versions to greatly simplify incorporating said changes in overrides elsewhere. It'll be more documentation on the Orchid side, but much easier for updating overrides in other Rails apps.

Things like this are also why we try to target overrides as narrowly as possible. Sometimes it becomes apparent we need to break down some of these templates into more partials. Might be the case we'll want to do that for the individual item type displays in search results here in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close? review then close in the news stuff relevant for African Poets in the News
Projects
None yet
Development

No branches or pull requests

5 participants