Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "nature of source text" encoding and remove key from display #245

Closed
kmcmullen opened this issue Aug 17, 2023 · 2 comments
Closed

Fix "nature of source text" encoding and remove key from display #245

kmcmullen opened this issue Aug 17, 2023 · 2 comments
Assignees
Labels
content relating to the content of the site (page text, etc) design design work/decisions high priority

Comments

@kmcmullen
Copy link
Contributor

We have decided that we will explicitly spell out the "nature of the source" text in each letter ("autograph letter signed," "typed copy unisgned," etc.). rather than use the code and then need to include the entire key.

We can probably just do a find-and-replace for the codes, and then we need to adjust the stylesheet to get rid of the key. Then we'll need to re-post all of the letters.

ccda.corr01044 and ccda.corr01182 both have the explicit classCode already encoded, as an example

@kmcmullen kmcmullen self-assigned this Aug 17, 2023
@kmcmullen kmcmullen added the content relating to the content of the site (page text, etc) label Aug 17, 2023
@kmcmullen kmcmullen added this to the Correspondence grant #2 milestone May 2, 2024
@kmcmullen kmcmullen added the design design work/decisions label May 2, 2024
@kmcmullen kmcmullen changed the title Fix "nature of source text" encoding Fix "nature of source text" encoding and remove key from display Jun 3, 2024
@kmcmullen
Copy link
Contributor Author

I tried to comment out the key in the "_show_bottom_metadata.html.erb" file on the dev branch, but it doesn't seem like it worked...?

@kmcmullen
Copy link
Contributor Author

With the expert help of Bianca and Brett (the BBs), we figured out what I did wrong. The key is now removed and we have found and replaced all of the classCode text. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content relating to the content of the site (page text, etc) design design work/decisions high priority
Projects
None yet
Development

No branches or pull requests

2 participants