Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download attachment with non-latin filename #302

Closed
ilyaglow opened this issue Sep 4, 2017 · 1 comment
Closed

Download attachment with non-latin filename #302

ilyaglow opened this issue Sep 4, 2017 · 1 comment
Assignees
@To-om
Labels
bug
Milestone
2.13.0

Comments

@ilyaglow
Copy link

ilyaglow commented Sep 4, 2017 •
edited
Loading

Request Type

Bug

Work Environment

Question Answer
OS version (server) CentOS
TheHive version / git hash 2.12.1
Package Type Docker

Problem Description

Downloading task log attachments with legit non-latin filename results to file with non-sense filename on disk.

Steps to Reproduce

  1. Create task in any case
  2. Add task log attachment with a file name "Проверка.txt"
  3. Try to download attachment - the file will be downloaded with the name that is not expected - something like --------.txt

Possible solution

Probably URL-encode of the filename may help
To-om added a commit that referenced this issue Sep 5, 2017
@To-om
#302 Encode filename when downloading attachment
dbaff4e
@To-om To-om self-assigned this Sep 5, 2017
@To-om To-om added the bug label Sep 5, 2017
@To-om To-om added this to the 2.13.0 milestone Sep 5, 2017
@To-om To-om closed this as completed Sep 5, 2017
@ilyaglow
Copy link
Author

ilyaglow commented Sep 5, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@To-om To-om

Labels
bug
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@ilyaglow @To-om