Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of cases overrides task log owners #303

Closed
derDuffy opened this issue Sep 8, 2017 · 3 comments
Closed

Merge of cases overrides task log owners #303

derDuffy opened this issue Sep 8, 2017 · 3 comments
Assignees
Labels

Comments

@derDuffy
Copy link

derDuffy commented Sep 8, 2017

Request Type

Bug

Work Environment

Question Answer
TheHive version 2.12.0

Problem Description

Describe the problem/bug as clearly as possible.

Steps to Reproduce

  1. Create case A (as user A)
  2. Create a few tasks and log entries in Case A (as user A)
  3. Create case B (as user B)
  4. Merge case A into case B (as user B)
  5. Observe that task logs originating from case A are assigned to user B now.

Possible Solutions

Review merge functions

@nadouani
Copy link
Contributor

nadouani commented Sep 8, 2017

Nice catch! Thanks @derDuffy

It's not a big deal to fix it, but I'll @To-om decide when he can fix it :)

@nadouani nadouani added the bug label Sep 8, 2017
@nadouani nadouani added this to the 2.13.0 milestone Sep 8, 2017
@To-om
Copy link
Contributor

To-om commented Sep 11, 2017

It is not easy to fix this issue because logs haven't owner, they only have creator (user who did the action).
When a case is merged, logs are created in the new case and the creator is the user who initiate the merge action.

To fix this issue, I can add a new attribute "owner" to log entity but a schema update is required. I can also hack entity creation process to overwrite creator value.

This can't be done for TheHive 2.13

@To-om To-om removed this from the 2.13.0 milestone Sep 11, 2017
@To-om To-om assigned To-om and unassigned derDuffy Sep 11, 2017
To-om added a commit that referenced this issue Sep 22, 2017
@To-om To-om added this to the 3.0.0 milestone Sep 22, 2017
@To-om
Copy link
Contributor

To-om commented Sep 22, 2017

@nadouani in front-end, use attribute "owner" instead of "createdBy" (or "user") to show the owner of the log. This will solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants