Boundary conditions in spline_builder_2d.hpp

[Paulinemoi]

It seems there is mix between the boundary conditions on the first dimension and the second dimension.
In spline_builder_2d.hpp, at lines

ddc/include/ddc/kernels/splines/spline_builder_2d.hpp

Line 382 in d652df8

if constexpr (BcXmin1 == ddc::BoundCond::HERMITE) {

and

ddc/include/ddc/kernels/splines/spline_builder_2d.hpp

Line 406 in d652df8

if constexpr (BcXmax1 == ddc::BoundCond::HERMITE) {

I think it should be BcXmin2 and BcXmax2 instead of BcXmin1 and BcXmax1 .
In the case of Hermite boundary conditions on the two dimensions, it doesnt seem to affect it. But when the 2D basis has Hermite boundary conditions for one dimension and periodic boundary conditions for the second dimension, we have a error at the compilation.

[blegouix]

Yes I think you are right!