Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings, keeping sign-compare warnings #237

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix some warnings, keeping sign-compare warnings #237

merged 3 commits into from
Nov 28, 2023

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau linked an issue Nov 21, 2023 that may be closed by this pull request
Fix warnings #236
Closed
@tpadioleau tpadioleau force-pushed the 236-fix-warnings branch 2 times, most recently from 218f019 to b6599d2 Compare November 22, 2023 07:36
@tpadioleau tpadioleau marked this pull request as draft November 22, 2023 09:37
@tpadioleau
Copy link
Member Author

tpadioleau commented Nov 22, 2023 •
edited
Loading

A bit of cleaning in the warnings:

  • regarding unused variables: I either deleted some, put the attribute [[maybe_unused]] or used some,
  • regarding the sign conversion: I suggest to disable the warning in the CI as long as the issue Use a signed integer type for DiscreteElementType #77 has not been completed,
  • there are still warnings for HIP, I can have a look if the upgrade of Kokkos helps, if it does we wait for Update to Kokkos v4.2.0 #238, if not we remove the warning. The warnings have disappeared with Kokkos 4.2.0.

@tpadioleau tpadioleau marked this pull request as ready for review November 23, 2023 14:18
@tpadioleau tpadioleau mentioned this pull request Nov 28, 2023
Open
@tpadioleau tpadioleau merged commit d0e74b8 into main Nov 28, 2023
42 checks passed
@tpadioleau tpadioleau deleted the 236-fix-warnings branch November 28, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbigot jbigot Awaiting requested review from jbigot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warnings
1 participant
@tpadioleau