Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about the correct usage of discrete_space #325

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Warn about the correct usage of discrete_space #325

merged 2 commits into from
Mar 6, 2024

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau linked an issue Mar 5, 2024 that may be closed by this pull request
Runtime error encountered when using discrete_space #287
Closed
@tpadioleau tpadioleau changed the title Warn about the correct usage of Warn about the correct usage of discrete_space Mar 5, 2024
@tpadioleau tpadioleau marked this pull request as ready for review March 5, 2024 16:56
yasahi-hpc
yasahi-hpc requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If calling this function inside a host function may cause a problem, it would be better to explicitly claim that.

include/ddc/discrete_space.hpp Outdated Show resolved Hide resolved
@CExA-project CExA-project deleted a comment from yasahi-hpc Mar 6, 2024
@tpadioleau tpadioleau merged commit 5fc335c into main Mar 6, 2024
42 checks passed
@tpadioleau tpadioleau deleted the 287-runtime-error-encountered-when-using-discrete_space branch March 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error encountered when using discrete_space
2 participants
@tpadioleau @yasahi-hpc