Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DiscreteElement class #53

Merged
merged 17 commits into from
Jun 7, 2022

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau linked an issue Mar 29, 2022 that may be closed by this pull request
@tpadioleau tpadioleau marked this pull request as draft March 29, 2022 17:04
@tpadioleau
Copy link
Member Author

@jbigot what do you think of renaming TaggedVector into DiscreteVector (thus removing the element parameter template) ? And replacing DiscreteCoordinate by DiscreteElement (no element template either ?) ?

@jbigot
Copy link
Member

jbigot commented Mar 30, 2022

Isn't there a lot of implementation in common that could be shared?

@tpadioleau
Copy link
Member Author

What implementation are you thinking of ?

@tpadioleau
Copy link
Member Author

tpadioleau commented Mar 30, 2022

Let a, b be discrete elements, u, v discrete vectors and x an integral, we need to define the following operators:

  • internal unary operations +u, -u,
  • external left binary operation x * u,
  • internal binary operations u+v, u-v,
  • right external binary operations a+u, a-u,
  • binary operation a-b,
  • 1d operations ++a, a++, ++u, u++.

I agree that it would make sense to allow implicit conversion of an integral to a 1-d discrete vector.

@tpadioleau tpadioleau force-pushed the 33-clearly-distinguish-discretecoordinatediscretevector branch 2 times, most recently from 358e798 to b1e5690 Compare April 1, 2022 15:42
@tpadioleau tpadioleau marked this pull request as ready for review April 28, 2022 13:33
@tpadioleau tpadioleau force-pushed the 33-clearly-distinguish-discretecoordinatediscretevector branch from 1aea0f3 to acac336 Compare May 5, 2022 08:53
@jbigot jbigot merged commit f83d687 into main Jun 7, 2022
@jbigot jbigot deleted the 33-clearly-distinguish-discretecoordinatediscretevector branch June 7, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearly distinguish DiscreteCoordinate/DiscreteVector
2 participants