Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create_mirror_view #561

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix create_mirror_view #561

merged 1 commit into from
Jul 26, 2024

Conversation

blegouix
Copy link
Collaborator

No description provided.

@blegouix blegouix requested a review from tpadioleau July 26, 2024 07:13
EmilyBourne
EmilyBourne requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This missing return was caught by Gysela's tests but wasn't caught by DDC's tests. This probably means that there is a test missing for this function. Could you add one to prevent this error reoccuring

@blegouix
Copy link
Collaborator Author

This missing return was caught by Gysela's tests but wasn't caught by DDC's tests. This probably means that there is a test missing for this function. Could you add one to prevent this error reoccuring

I'm sorry but it becomes very hard to add new things to my TODO list ^^. I don't see any test for create_mirrors, so I prefer to open an issue.

tpadioleau
tpadioleau approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes my bad

@blegouix blegouix merged commit bfb055c into main Jul 26, 2024
49 checks passed
@blegouix blegouix deleted the fix-create-mirror-view branch July 26, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

@EmilyBourne EmilyBourne EmilyBourne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blegouix @EmilyBourne @tpadioleau