Simplify fft full normalization #663

tpadioleau · 2024-10-13T11:11:10Z

The "full" normalization can be simplified by defining a 1d normalization factor that would also avoid duplication

fix double implicit usage through Kokkos::numbers::pi
introduce two functions to help reading the normalization factors and the link between the forward and backward transformations

yasahi-hpc

LGTM
Could you please comment about the consistency between Real and real_type_t<Tout>

include/ddc/kernels/fft.hpp

tpadioleau · 2024-10-15T12:03:27Z

tpadioleau self-assigned this Oct 13, 2024

tpadioleau force-pushed the simplify-fft-full-normalization branch from 5d54142 to ac3b30a Compare October 13, 2024 11:12

tpadioleau added 7 commits October 13, 2024 23:14

Make a 1d full normalization

b09b2ba

Remove usage of the select function

c9a0854

Rename template parameters

72bce1b

Use rlength

09439ae

Reorganize computation

a6f9f52

Reuse forward_full_norm_coef

4520b94

Use value instead of get

2a1cb65

tpadioleau force-pushed the simplify-fft-full-normalization branch from ac3b30a to 2a1cb65 Compare October 13, 2024 21:14

tpadioleau requested a review from yasahi-hpc October 15, 2024 05:16

yasahi-hpc previously approved these changes Oct 15, 2024

View reviewed changes

include/ddc/kernels/fft.hpp Show resolved Hide resolved

yasahi-hpc reviewed Oct 15, 2024

View reviewed changes

include/ddc/kernels/fft.hpp Show resolved Hide resolved

Review from Yuuichi

4c95c14

tpadioleau dismissed yasahi-hpc’s stale review via 4c95c14 October 15, 2024 09:52

yasahi-hpc approved these changes Oct 15, 2024

View reviewed changes

tpadioleau merged commit fc0aa21 into main Oct 15, 2024
56 checks passed

tpadioleau deleted the simplify-fft-full-normalization branch October 15, 2024 12:03

Provide feedback