-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding version information in the KGO #50
Comments
Would it be beneficial to use git lfs for the creation and versioning of the KGO files within the workflows? The files are not that big and can be stored in a separate repo that will be cloned only by a script so that bandwidth and data quotas are not used up that much. |
When I looked into this I concluded that we would hit the bandwidth limit easily, but I may not be understanding how it works. |
I just assumed that testing is only needed for contributors and action runs and given the size of all datasets is around 100 Mb, unless you get >10 answer-changing PRs a month - the bandwidth quota won't be met. Especially, if the testing description is moved to the wiki for developers, so the general users won't use it much. |
Currently, the test datasets are downloaded every time the CI tests are triggered (push, pull request), so my understanding is that the bandwidth limit will be hit after 10 tests. If my understanding is correct, then we would have hit the bandwidth limit during the last couple of weeks. |
Oh. Ok. Then what can be done is: in the workflows and in' With regards to the versioning of the files, instead of vXXX, the filenames can contain creation date and tag/commit they were created with and in |
Sorry for my slow reply. That sounds like a nice approach. I'm not familiar with google apps scripts, would you be able to provide guidance on how to to do that? For the moment, I'd like to keep the vXXX versioning, and perhaps move to date/tag in the future. |
You can add a script at https://script.google.com/home/start (documentation).
function write_nc_list() {
var listfile = DriveApp.getFileById('.<txt file id>')
var folder = DriveApp.getFolderById('<folder id>');
var list = [];
list.push(['Name','ID','Size']); // comment this out if you do not need the header
var files = folder.getFiles(); //
while (files.hasNext()){
file = files.next();
var row = []
var fname = file.getName()
if (fname.includes('.nc')) {
row.push(file.getName(),file.getId(),file.getSize())
list.push(row);
}
}
listfile.setContent(JSON.stringify(list))
}
|
In the PMC on 29 May 2020, there was some discussion about encoding the KGO with some version information. It was agreed that it was a nice idea only if it can be done automatically by the CI test. This issue will explore the possibility of automatically updating that information to the KGO when the CI test fails.
The text was updated successfully, but these errors were encountered: