Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module imports not working on Windows #2

Closed
CFiggers opened this issue Oct 9, 2023 · 4 comments
Closed

Module imports not working on Windows #2

CFiggers opened this issue Oct 9, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@CFiggers
Copy link
Owner

CFiggers commented Oct 9, 2023

At the moment, a module import such as (import spork/json) causes an error on Windows. This seems to happen with all module imports that are not project local.

@sogaiu
Copy link

sogaiu commented Oct 10, 2023

Not Windows, but seemingly similar issue for a non-root install of janet on a linux box:

import-spork-vscode-janet-lsp

@CFiggers CFiggers added the bug Something isn't working label Oct 13, 2023
@CFiggers
Copy link
Owner Author

@sogaiu I just published a pre-release version of Janet++ that bundles Janet LSP as a .jimage rather than a compiled executable. This means that when the Language Server starts up, it will be running on the user's locally-installed copy of Janet (assuming janet is on the user's path, which it ought to be). In my preliminary testing, this seems to fix the module import issue, since the Language Server is running as the user's own install which means it should discover modules the same way any other invocation of janet on their system would.

Would you like to test this on your non-root Void Linux install? You can do so by switching to the Pre-release version on the extension page in VS Code:

image

@sogaiu
Copy link

sogaiu commented Oct 27, 2023

@CFiggers Thanks for the heads up.

I gave it a try and it seems to be working better 👍

@CFiggers
Copy link
Owner Author

Fixed in Janet++ by running the LSP from a .jimage rather than a compiled executable. May need to revisit in the future if Janet LSP will be a stand-alone CLI tool in addition to editor integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants