PMP: Add a function to find edges with smallest/largest dihedral angle #8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::max_element demands a forward iterator, which we do not have
for Polyhedron_3: its iterator type is a boost transform_iterator
with the edge_descriptor built on-the-fly when dereferenced.
The error in practice is a static assertion for compilers
that do in fact enforce the requirement of the iterator category
like:
error: static assertion failed due to requirement
'std::is_same<
boost::iterators::detail::iterator_category_with_traversal<
std::input_iterator_tag,
boost::iterators::bidirectional_traversal_tag>,
std::forward_iterator_tag>::value'
We could probably have an iterator with state or something, but
it is not worth it for now...
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8676/v0/Manual/index.html |
|
Successfully tested in CGAL-6.1-Ic-59 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Both functions now have the same API: std::pair<std::pair<boost::graph_traits<PolygonMesh>::edge_descriptor`, FT>,
std::pair<boost::graph_traits<PolygonMesh>::edge_descriptor`, FT> >
minmax_XXX(const EdgeRange& edge_range,
const PolygonMesh& pmesh,
const CGAL_NP_CLASS& np = parameters::default_values())An annoying detail is that we compute and compare to current min/max rather than using |
|
These functions are trivially paralleliozable. Do we take care of that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add the function
minmax_dihedral_angle()to identify the non-border edges with smallest/largest dihedral angle.It returns the edge descriptors and the angles in degree.
Release Management