Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts & Icons Inclusion #61

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Fonts & Icons Inclusion #61

merged 13 commits into from
Nov 14, 2024

Conversation

rsh52
Copy link
Contributor

@rsh52 rsh52 commented Nov 14, 2024

This PR seeks to implement support for FontAwesome and Bootstrap icons. Free, open source licensed font files have been included under /inst and are installed and configured with the package.

List of changes:

  • All related user-facing functions are under font.R
    • Associated tests under the test suite
  • Developer scripts for creating/updating font files and their inclusion into the package are under data-raw/
    • Python's fontTools library incorporated to assist with unpacking TTF files
  • Gallery and select pkgdown documents updated

Future considerations:

  • A note occurs when running RCMD Check related to file size, due to the font files themselves. Since the intention is to have these available to users I'm unsure if this will be allowed or not.

Closes #60

@rsh52 rsh52 added the enhancement New feature or request label Nov 14, 2024
@rsh52 rsh52 self-assigned this Nov 14, 2024
@rsh52 rsh52 merged commit 17fc974 into main Nov 14, 2024
11 checks passed
@rsh52 rsh52 deleted the fontawesome-dev branch November 14, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support FontAwesome Icons for Markers
1 participant