From 182030d49ca12aa429fdca7bfda70ee67354ad75 Mon Sep 17 00:00:00 2001 From: Philippe Blain Date: Thu, 12 Oct 2023 13:21:47 -0400 Subject: [PATCH] icepack_parameters: don't recompute constants in icepack_query_parameters (#465) All parameters of icepack_parameters::icepack_query_parameters are intent(out), so it does not make sense to recompute constants at the end of that subroutine since no constants are changed. This superfluous call dates back to the introduction of icepack_query_parameters (then called icepack_query_constants) in 7646f2a (Migrate icepack_constants out of the columnphysics/constants directory..., 2017-10-04). Remove that call. --- columnphysics/icepack_parameters.F90 | 3 --- 1 file changed, 3 deletions(-) diff --git a/columnphysics/icepack_parameters.F90 b/columnphysics/icepack_parameters.F90 index 02deaae9a..f875409b5 100644 --- a/columnphysics/icepack_parameters.F90 +++ b/columnphysics/icepack_parameters.F90 @@ -1799,9 +1799,6 @@ subroutine icepack_query_parameters( & if (present(sw_frac_out) ) sw_frac_out = sw_frac if (present(sw_dtemp_out) ) sw_dtemp_out = sw_dtemp - call icepack_recompute_constants() - if (icepack_warnings_aborted(subname)) return - end subroutine icepack_query_parameters !=======================================================================