Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo—vertResolution might be intended as horizontalResolution #12

Open
SableRaf opened this issue Jan 3, 2025 · 2 comments
Open

Possible typo—vertResolution might be intended as horizontalResolution #12

SableRaf opened this issue Jan 3, 2025 · 2 comments

Comments

@SableRaf
Copy link
Contributor

SableRaf commented Jan 3, 2025

In encode.js, I noticed that vertResolution seems to refer to the number of pixels per line, which would make it a horizontal resolution rather than vertical. Based on the explanations in the SSTV handbook, this might be a typo, and renaming it to horizontalResolution (or pixelsPerLine) could help clarify its meaning.

That said, I might have misunderstood, so please feel free to clarify if I’ve gotten it wrong!
@CKegel
Copy link
Owner

CKegel commented Jan 10, 2025

As I've been working through the decoder - I noticed that as well. I've been thinking pixelsPerLine or similar may be the best name - but I'll take a look this weekend to be sure!

@SableRaf
Copy link
Contributor Author

SableRaf commented Jan 10, 2025 •
edited
Loading

Exciting to read you've been working on the decoder!!

I spent some of my free time over the holidays building a proof of concept based on Web-SSTV and p5.js.

The code is here: https://github.com/nestofbirbs/sstv-p5-demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SableRaf @CKegel