Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag summing #243

Open
henryiii opened this issue Feb 28, 2019 · 3 comments
Open

Flag summing #243

henryiii opened this issue Feb 28, 2019 · 3 comments
Milestone

Comments

@henryiii
Copy link
Collaborator

This is just a note to myself to verify that the generalized flag types from #235 are the best they can be before 1.8.

@henryiii henryiii added this to the v1.8 milestone Feb 28, 2019
@henryiii henryiii self-assigned this Feb 28, 2019
@phlptp
Copy link
Collaborator

phlptp commented Mar 1, 2019

One thing I have been wondering is if the default behavior of summing the flags with an integer output should be turned off in favor of take last if flags have a defined default through {xxx} or !. It probably makes sense to keep the summing behavior if all the flags just default to to true for backwards compatibility, but if there are others not sure it makes sense as the default. The callback would still be summing, but it would default to only summing a single element.

@henryiii henryiii removed this from the v1.8 milestone Dec 31, 2019
@henryiii
Copy link
Collaborator Author

Does anything need to be checked here (such as for summing) or can it be closed?

@henryiii henryiii removed their assignment Dec 31, 2019
@phlptp
Copy link
Collaborator

phlptp commented Dec 31, 2019

I think it might make sense to change the default behavior slightly for the summing flags in 2.0 but otherwise I think it is ok for the time being. I haven't found any oddities in the last couple months.

@henryiii henryiii changed the title Investigate flag defaults and ignoring assignment Flag summing Dec 31, 2019
@henryiii henryiii added this to the v2.0 milestone Dec 31, 2019
@phlptp phlptp mentioned this issue Jan 1, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants