remove codecov from ci #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
reviewed
Apr 24, 2024
| name: codecov-umbrella # optional | ||
| fail_ci_if_error: true # optional (default = false) | ||
| verbose: true # optional (default = false) | ||
| - name: Archive code coverage results |
There was a problem hiding this comment.
I was thinking of removing this portion instead? https://github.com/CMSgov/bcda-app/pull/933/files#diff-e42b2b9794d0333e41c8e218ece5897ea7395746b5e07d08fb85b53e36d15043L71-L74
If we remove the codecov report generation but keep in the artifact, would it fail when it searches the path for the testcoverage.out?
There was a problem hiding this comment.
That's what I'm thinking; it's going to look for code-coverage-report and then fail
There was a problem hiding this comment.
go has built-in test coverage tools, so the file still gets generated, from what I can tell.
alex-dzeda
reviewed
Apr 24, 2024
.github/workflows/ci-workflow.yml
Outdated
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: code-coverage-report | ||
| path: ./test_results/latest/testcoverage.out |
alex-dzeda
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
n/a
🛠 Changes
removing codecov from CI, since sonarqube is doing the same thing and tokenless is hitting a github api limit.
ℹ️ Context for reviewers
Link to discussion on tokenless codecov generation and rate limiting.
✅ Acceptance Validation
n/a
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.