Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-3176: Upgrade Go version to 121 #682

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

OddTomBrooks
Copy link
Contributor

EASI-3176

Changes and Description

  • Change Go version from 1.18 to 1.21

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@OddTomBrooks OddTomBrooks requested review from a team as code owners September 6, 2023 17:09
@OddTomBrooks OddTomBrooks requested review from ClayBenson94 and removed request for a team September 6, 2023 17:09
@OddTomBrooks OddTomBrooks changed the title chore: upgraded go version to 121 with fixes for go buildvcs issue EASI-3176: Upgrade Go version to 121 Sep 6, 2023
@StevenWadeOddball StevenWadeOddball removed the request for review from a team September 6, 2023 20:54
@Jdwoodson
Copy link
Contributor

Jdwoodson commented Sep 8, 2023

@OddTomBrooks @ClayBenson94 These three linters are all abandoned and have been moved to disabled by default in later versions of golangci-lint
golangci/golangci-lint#1841

I'm going to update our version of golangci-lint in our pre-commit config and see if that resolves the issue.

EDIT You already did this.

@OddTomBrooks OddTomBrooks merged commit efec51e into main Sep 11, 2023
9 checks passed
@OddTomBrooks OddTomBrooks deleted the EASI-3176/upgrade_go_version_118_to_121 branch September 11, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants