Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit event #258

Open
rya-sge opened this issue Jan 11, 2024 · 1 comment
Open

Emit event #258

rya-sge opened this issue Jan 11, 2024 · 1 comment
Labels
Pause The issue is paused

Comments

@rya-sge
Copy link
Collaborator

rya-sge commented Jan 11, 2024

We should emit events for variables initialized inside an initialize function

@rya-sge
Copy link
Collaborator Author

rya-sge commented Jan 19, 2024

It is only an addition in BaseModule, but it increases the contract code size of +0.296.

It is not a lot, but we are too close of the maximum size limit

    function __Base_init_unchained(
        string memory tokenId_,
        string memory terms_,
        string memory information_,
        uint256 flag_
    ) internal onlyInitializing {
        tokenId = tokenId_;
        terms = terms_;
        information = information_;
        flag = flag_;
    }

@rya-sge rya-sge added the Pause The issue is paused label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pause The issue is paused
Projects
None yet
Development

No branches or pull requests

1 participant