Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporating NeuroLibre data into CONP #761

Open
emmetaobrien opened this issue Apr 6, 2022 · 11 comments
Open

incorporating NeuroLibre data into CONP #761

emmetaobrien opened this issue Apr 6, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@emmetaobrien
Copy link
Collaborator

emmetaobrien commented Apr 6, 2022

The proposed initial approach is that individual NeuroLibre datasets will show up on Zenodo with the appropriate flag for ingestion into CONP. Alternatively, they could be loaded manually using standard procedures. Examples for testing this process would be useful.

The NeuroLibre publication information will go in the primaryPublication field and subfields in the DATS model as usual. Currently publication information in CONP pages links back to the online primary publication via DOI in many cases; we should confirm that this will work for NeuroLibre.

The connection between a NeuroLibre dataset and the source dataset should use the extraProperties->derivedFrom relationship in DATS.json, and the GUI and/or user-facing documentation should make this clear. As this is a property we added ourselves, I see no difficulty with extending it to include multiple values as needed in the longer term (though it is potentially confusing nomenclature, as the core DATS schema has a property derivesFrom referring to the biological material from which a sample is taken).

Linking from a parent dataset to derived datasets is already managed in a back-end table so should not need any changes to DATS.json. (@cmadjar could you link to some documentation of this functionality here?)

Once we get this more clearly sorted out and tested I will update user and developer-facing documentation as necessary.

@emmetaobrien emmetaobrien added the enhancement New feature or request label Apr 6, 2022
@cmadjar
Copy link
Collaborator

cmadjar commented Apr 6, 2022

In the backend database, when a dataset is added to CONP, there is a table called dataset_ancestry that stores the dataset relationship based on the DATS extra property derivedFrom. The table structure is as follows:

  • id
  • parent_dataset_id (example: projects/bigbrain-datalad)
  • child_dataset_id (example: projects/BigBrain_3DROIs)
  • date_created
  • date_updated

The code of the portal will then query that table to display the relationship between parent datasets and child datasets if there are any linked to the dataset displayed.

@emmetaobrien
Copy link
Collaborator Author

Does that all work automatically, or is any manual intervention needed?

@cmadjar
Copy link
Collaborator

cmadjar commented Apr 6, 2022

There is a cronjob on the portal that automatically runs flask update_datasets every 15 minutes and that command will update the dataset_ancestry table when there are relationships between datasets.

Then the code reads that table for proper display of the relationships between datasets.

@emmetaobrien
Copy link
Collaborator Author

Excellent.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue is stale because it has been open 5 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

This issue was closed because it has been stalled for 3 months with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2022
@emmetaobrien emmetaobrien reopened this Dec 5, 2022
@github-actions github-actions bot removed the Stale label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2023

This issue is stale because it has been open 5 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label May 6, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This issue was closed because it has been stalled for 3 months with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
@emmetaobrien emmetaobrien reopened this Aug 7, 2023
@github-actions github-actions bot removed the Stale label Aug 8, 2023
Copy link

github-actions bot commented Jan 6, 2024

This issue is stale because it has been open 5 months with no activity. Remove stale label or comment or this will be closed in 3 months.

Copy link

github-actions bot commented Jun 7, 2024

This issue is stale because it has been open 5 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Jun 7, 2024
Copy link

github-actions bot commented Sep 5, 2024

This issue was closed because it has been stalled for 3 months with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@emmetaobrien emmetaobrien reopened this Sep 5, 2024
@github-actions github-actions bot removed the Stale label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants