-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back-compatibility with old forcing.json format #75
Comments
Runs with a standard config fail with the latest libaccessom2 70e2c46 with message
This assertion was added in a451a7f. But weirdly, these configs work with 0ab7295 despite it being newer than a451a7f and 467e3e2 - see https://github.com/COSIMA/libaccessom2/commits/master |
Ah, I see - a451a7f and 467e3e2 were on branch 242-era5-support, which was later merged with 0ab7295. We should fast-forward branch 242-era5-support to 70e2c46 (the current head of master), and change 242-era5-support shouldn't be merged into |
I fast-forward branch 242-era5-support to 70e2c46 via
(probably didn't need all the Still need to change |
@micaeljtoliveira, @nichannah, @aidanheerdegen, @russfiedler, @penguian, just a heads-up that I'm about to reset the commit that
so you might notice some weirdness next time you pull. |
|
The current libaccessom2 master has breaking changes to the
forcing.json
format, in particular a451a7f and 467e3e2 which were made to support ERA5.Consequently the standard ACCESS-OM2 configurations are incompatible with the latest libaccessom2 - see COSIMA/access-om2#262.
It would be much nicer to support both the old and new formats. This backwards compatibility would probably require a version number in
forcing.json
(which would signify the original format if absent).The text was updated successfully, but these errors were encountered: