Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for 0.16 #385

Merged
merged 15 commits into from
Nov 13, 2018
Merged

Fixes for 0.16 #385

merged 15 commits into from
Nov 13, 2018

Conversation

superbock
Copy link
Collaborator

@superbock superbock commented Oct 19, 2018 •
edited
Loading

Changes proposed in this pull request

This PR is a collection of smaller fixes for the upcoming 0.16 release.

It solves a couple of (smaller) issues, more notably are:

  • using pytest instead of nose resolves the issue of failing Travis build for Python 3.6+, which failed due to failing doctests in madmom.ml.nn.layers when being run against a cythonised version of it.

@superbock superbock added this to the v0.16 milestone Oct 19, 2018
@superbock superbock force-pushed the fixes_for_0.16 branch 2 times, most recently from d08584e to 68e17ae Compare October 19, 2018 15:08
@superbock superbock requested a review from fdlm November 12, 2018 10:18
@superbock superbock changed the title [WIP] Fixes for 0.16 Fixes for 0.16 Nov 12, 2018
move doctest setup routines to a location actually checked by pytest
02056f6 
the previously working solution was exploiting a bug in pytest 3.10.0
fdlm
fdlm approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@fdlm fdlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@superbock superbock merged commit 82c9248 into master Nov 13, 2018
@superbock superbock deleted the fixes_for_0.16 branch November 13, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdlm fdlm fdlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@superbock @fdlm